label.py: Fix Label when initial text is not provided #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change addresses cases when Label class is initialized with max_glyphs instead of text. In such cases, the split function is attempted on None object instead of an empty string: File "/lib/adafruit_display_text/label.py", line 84, in __init__ AttributeError: 'NoneType' object has no attribute 'split' Fixes: adafruit#141
|
@jposada202020 Please review this change! |
|
@flavio-fernandes |
FoamyGuy
approved these changes
Mar 13, 2021
There was a problem hiding this comment.
@flavio-fernandes thank you for this fix!
These changes look good to me. I recreated the issue mentioned, and successfully tested these changes as a solution using Blinka_Displayio.
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Mar 14, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.16.0 from 2.15.5: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#133 from FoamyGuy/new_font > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#134 from jposada202020/tab_replacement > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#142 from flavio-fernandes/fix.init.wout.text Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_Layout to 1.2.1 from 1.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_Layout#10 from kmatch98/switch_round > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_Layout#12 from FoamyGuy/adding_icon_widget
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses cases when Label class is initialized with
max_glyphs instead of text. In such cases, the split function is
attempted on None object instead of an empty string:
File "/lib/adafruit_display_text/label.py", line 84, in init
AttributeError: 'NoneType' object has no attribute 'split'
Fixes: #141